I do recall us requesting the ability to turn off the sun many moons ago
also the ability to dynamically move it.

@cybernescence

if you could actually help here, it would be amazing. Your knowledge about gameguru never ceases to amaze me.

@Duch - there are a lot of light references in this shader all over the place, not sure I caught them all and only those relating to the sun - however before I spend any more time, if you'd like could you try the attached one to see if I'm going in the right direction with what you want.

Basically the Surface Sun Factor slider should reduce (turn-off when at zero) the dynamic sunlight on the scene, so only the ambient slider adds general background illumination and dynamic lights. So this should also adjust specular light and shadows from the sun too.

Please keep a back-up of your stock abpr_core.fx and when replaced with the attached you'll have to do the forceloadtestgameshaders=1 in setup.ini for the first use to recompile the shaders.

@Teabone - dynamically moving the sun is a non-trivial task, need to:

work out vectors from the rotation angles
sync the sky box sun position to sun angles
adjust the light direction for all of the shaders, for specular reflections
sync the light ray control angle to sun angle
move the directional shadow camera to move the shadows to sun angle
for day/night - blend sky boxes (DBP code for this is in the source and works when converted, with some shader changes too)
add some lua commands to control it all (the easy bit)

It will arrive at some point via me or someone else if they get there first

Cheers.

Is there any sort of fix for this? This just started happening to me when trying to lightmap my levels.. It completely ruins the entities, unless you switch back to real-time lighting. I was hoping it was a bug that would be fixed with the last update. :/

Outstanding yet again. No more sun specular on an interior level for me. This is a light mapped level I am testing on.

I will make a video.


But I am tweaking it a bit.

Before the shader update. (notice the white specular reflection on the floor)


After the new shader update.



Definitely have better control over the blending of ambient, and surface.


Thank you.

This is fantastic !!! In my indoor level and looks perfect

That looks good thanks for trying it out .

Does the flashlight look ok with this tweak?

I think the surfacesunfactor lua command is stock? So can use that to gradually ramp up/down the sun as exit/enter interiors too.

Cheers.

oh my ! Amazing work cybernescence !!

I just saw the post and the images I will try it now

Well it has been around for a while now - since PBR was introduced - and has been reported on github. So it may take some time before a fix comes.

My guess is that after the lightmap process the _Illumination map is mistaken for the _detail map (which is meant to be tiled over the model), but I am only guessing.

It just needs Lee to take a look at it, but he is likely busy with other stuff.

Best to either run in real-time only, or don't use _illumination maps for now....

Reliquia....

@cybernescence - excellent stuff

Reliquia....

YES this is a confirmend FIX.

Amazing man, thank you so much cybernescence

BEVORE


AFTER

Now all we need is no terrain ,more chance of meeting the pope I think

Dave

The terrain thing is interesting. When it’s gone what reference point would GG use to place entities on? With physics items would just fall unless resting on another immobile entity. Just talking out loud and I definitely see what is being asked for but might be some things to wrestle with to achieve it.

Cheers.

Flashlight works great with this shader now.

nice work cybernescence

yes the no terrain thing is a little more complicated because no terrain = no collision I think you would still need an invisible flat plane as a reference point for the collision system to work a massive single sided plane is probably the best to start with I think

Or your own terrain objects that you can control the poly count with.

EDIT:
Here is the video I promised. I got the flash light in also.

I really want to know why this slider should work only with a lightmapped level. Preben?

It looked so much like a feature, cause it is not even hard to add....

Let´s see what the new year roadmap brings.

@cybernescence
Do you add it to the source? Or should I create a pull request? It fix this specific problem, so we could close some issues on github with it.

I bet it includes some DLC's

@cybernescence

I actually found a small isse with your shader-

When you have some ambient lighting going on in your level - and you activate the flashlight, the ambient lighting will set to zero.
I just noticed this in the editor.