Hey all, as many of you may know I've been deep in LUA every day always testing things out and creating new features and improving upon the types of games I can make with GG. While I'm quite new to LUA ive been able to fix many of the issues that used to bug me that i never thought id be able to fix myself. I've also been able to take off quite a number of "features" off the list we have.

Right now I've been working on getting rid of the instant death when the player submerges underwater. As I noticed its been a reoccurring complaint with players of Game Guru created games and also from the developers. While there may be already ways to avoid this , I've decided to actually modify the player's global controls, instead of creating an additional script. So it will just work as soon as you start your game.

So for now here is what I have modified:

- No longer instantly die in water
- Can jump into water from great heights and not die from fall damage
- automatically puts weapon away once submerged
- there is a timed delay before you start losing health
- you lose health slowly once you start to run out of air
- works with 3rd person (no swimming animations yet)
- if health regeneration is enabled on the map, you wont recover health till you surface







I'm considering creating new variables. So that if someone nice enough who has some experience in C++ with modifying the UI in GG, could add a section for swimming to the player start marker.

What I'm working on next:

- ability to swim in an upward direction
- remove hurtfall sound when falling in to water (leaving splash sound)
- remove blood spurts on screen when drowing (keep red fog for when dying)
- add possible splash decals
- adding swimming animation to 3rd person player once submerged
- use the existing code for weapon types that could be used underwater


Before i really start hacking away at the global player controls scripts however, I plan to just create something that is working that is basic to prevent the acid or lava feeling that is in currently in GG. So you can enter water and leave without you dying instantly. I'd like to share that once its more refined.

Nice work so far Teabone Looking good ,I no a lot of people have been asking for this .

Dave

well done with this Teabone.

Hmmm .......
An underwater entrance to a cave or a facility ..

now you and corno have really done some great work here.



under water swimming sounds awesome

That's Great! This will sure come in handy.

Awesome work Teabone can you do bubbles LOL

awesome thank you Teabone.

this adds more game play for instance think of tomb raider, having to find underwater air pockets or drown etc.

An interesting thing i noticed is that the water plain shader seems to only really effect the surface of the water. If you go beneath it and look up you will only see the last captured reflection. So if your in a cave and look up you may see the sky and trees. So this would require some modifications to the water shader and possibly the plain itself.

A bit of a test of diving, surface treadding and small cave test:

this is awesome! lee should include this in gameguru

Nice work Teabone. Apart from the reflection issue, this is great.

Another great series of videos showing your talents. Nice work

Thanks all

I've now added a more realistic timed delay before health starts depleting -- without adding any new variables that may cause conflicts (no new variables at all presently). Trying to keep these modifications as light as possible so that we have a foundation to build from that won't complicate things too much. Because its very easy to add new variables and huds and things for airtimers and such but i think as long as I can craft the base of this , it might be a good enough replacer for the instant water death aspect of GG which is seeming to gain a bad reputation. And we can then push it towards the master on github.



The one remaining issue i see here however is the water shader seems to not work the same while looking at it from above. So I may need some assistance around modifying the water shader so that it can work while underwater. Since shader values can be altered via LUA now however, i might be able to figure out a workaround.

The swimming modification do come with several modifications to the health system as well. For instance the annoying heartbeat and red screen that seems to occur even if the player is at just 99/100 health... doesn't occur until the player is at about 60% health (starting health divided by 1.5). I have seen Steam and Youtube comments about this being a problem for some people.

Most games if not nearly all, don't give heartbeat and red screen effects/indicators to the player unless the player is in a critical damaged phase this being below 60% and sometimes even as low as 25%. So that is the intent of this modification. Also it helps maintain the underwater visuals without forcing red on to the screen (until only when you are actually close to drowning). Since we already have a damage indicator with the direction damage dial that appears when injured and blood spurts on screen, there is no need to add the extra level of effects when the player is at a reasonable state of health.

the 3rd Update to the Swimming script shows a bit of how the health would now be handled (if this contribution is merged to the master).

Due to these modifications being more than just swimming, I may throw this to the github as more then just a swimming foundation addition but rather a patch to the player controls as a whole that can be continuously improved upon. I've been meaning to also make the player go into swimming animation while in 3rd person and also improve upon the 3rd person controls in general.

What's really cool about being able to go in water in Game Guru now is you could add items in water that the player can collect, or give him/her other ways of entering bases and alike. I will be putting together an example of how these improvements work with the EBE so you can have flooded rooms and etc.

cant you implement the " Players_noredscreen.lua " to rectify that ?
If that's daft then ignore me I'm no scripter ..

We should not disable it entirely. The users should always have that option themselves (so the code you provided in a separate script would work still for that). We should not integrate that in the global controls directly or else the player won't be able to enable.

What this modifications does is only emit the effects when the player is in critical health (60% or less) rather than if missing a point off health. Its implemented into the global player controls and its working pretty great so far with no conflicts. I'm also open to working with someone in C++ to add more player marker options for customization. Right now its using a hard value of 1.5 value to division of the maximum/starting player health. But this could be changed to use a variable that the editor could read so we could set at what point does the critical health alerts and red fog start.

I didn't realize there was a command for that. I just commented it out in the "gameplayercontrol" script. Probably all of my games I don't want that. However, T-bone, I like the idea of having options available somewhere including the percentage amount.

Yep and even if these modifications make it to the master build for Game Guru, the script synchromesh has provided and its command would still work to disable.

Wha are the chances of getting cool fpsc water shaders like Uzi's in GG? :p

@Teabone, Thanks for the fpsc vid link. And grats on the swimming, awesome videos also.

I think we need him in GG. All his shaders are looking great, but I dont know why he not come over. I asked him several times now

Is that shader working in Preview version? Apparently it needs to be HLSL level 5.0 or above. That's an error I keep getting with "effect_animate64.fx" I've been trying to get Bolt Actions attention once again. I have not been able to figure out how to start a new ticket for the store and apparently I'm not allowed to post in the store forum because it doesn't ever post. The fx file comes with his weather script and decals.

@Flatlander - to get rid of the error with effect_animate64 you need to set forceloadtestgameshaders to 1 in the setup.ini file. Once you've run a test game, you can set it back to 0. This worked for me.

This is great work, we have needed something like this for some time. Nicely done.

Thanks Taz

Before I can submit anything to the github, I think I'll need to progress the 3rd person functionality a bit more. Since the swimming addition effects both FPS and 3rd Person by default. But when the 3rd person player walks into water it appears as him just kind of floating and walking.

Thankfully though we do have the animations for swimming with the main biped we are using with GG.



Its going to take a while to get this working as intended. Will have to scan to make sure the player is at just the right depth before switching from and to swimming animations. We have treading animations and swimming so at the least i have enough to work with.

I'm really excited about this. Thanks for your work.

If one of the Github gurus is around, could you help me out with the questions I have around the recent pull request I've sent to the master?

https://github.com/TheGameCreators/GameGuruRepo/pull/140

I have submitted the improvements from this thread as a pull request though am curious as to why it shows 3 commits. Wondering if it does this just to show my entire history of commits? Or does this mean that each time I send over a pull request it will send over yet again my past commits? I noticed it says only 1 file changed which seems to mean to me i shouldnt have anything to worry about.

Also it shows the entire 1700 lines in the script as conflicting (on github) with the master script; yet in notepad++ it shows only a few lines of changes, rather than marking the entire script in yellow. Am I doing everything correct here?

---

I've rephrased this modification to "improved drowning", as it currently is an improved way of handling when the player enters water and doesnt yet allow for the player to swim completely (cannot research without near by slopes). Its simply the foundations what will allow for swimming at present. If the pull request gets merged to the master - from here we can work on fine tuning it, so we can begin replicating swimming in first person and third person similar to how they function in AAA games.

This modification in its current state is just to fix the acid effect of water in Game Guru.

@Teabone : I also noticed that for some reason your LUA script is being determined as completely different from the master one. It could be the text editor you used to load the LUA and then save it out changed some of the line structures (CR/LB/etc). If you use something like WINDIFF, you can go through your LUA changes and try again with a fresh copy of the "gameplayercontrol.lua" from the master repo. I can then see the changes individually, and get the changes tested and eventually part of the master build. Also only make a pull request when you are completely finished with the changes you want to make for that particular task, so we are reviewing and accepting a finished, tested and final version of the code, thanks!

To All, is everyone happy with the "slow-drown" change in functionality as anyone working on a game which depends on instant death when in water would find the new update will break their games functionality and possibly gameplay flow. Also if we keep this feature, I will need to fix the refraction effect when looking through the water surface above the water line.

I'd say put the slow-drown in and add a new script to put into a trigger zone that kills you instantly when you enter it, that way we have both capabilities.

What about first person swimming/drowning? I guess the flailing arms animations will have to be made from scratch...?

Going to see whats up with the LUA script that shows every line as conflicting. Other comparison software should help indeed. In the following image in the attachment is how it appears in comparison in notepad++. Results.

EDIT: I used WINDIFF's "compare it" software and it yields same results showing only the lines that are different compared to the master and not the entire file. Strange. Results

Since I'm no good at C++ I was hoping someone might be able to help out here with adding in the player start property panels an option for either enabling or disable instant drown (probably best option) I could then add a variable switch we could use for that in the script or a field for the ability to modify the drown timer variable (which already exists in the script).



This is also another solution too. I could also just throw a script together someone could throw on a barrel in their map that if always active will detect if player is below the water line and instantly kill them as it normally does.



Preben said it might be able to take a look at it to see if its an easy fix. When i get the code fixed up i'll send over the globalplayer controls script.

I posted this request to coincide with the script:
https://github.com/TheGameCreators/GameGuruRepo/issues/133

@Teabone, Great work, supporters this way on your progress. All the best.

Teabone:

Added some underwater shader stuff , and fixed your reflection issues. I will release this for GameGuru Loader first , as this already work. Then we can start to test your changes in GG, and get some great under water scenes going



Under water FOG now follow your slider settings (not just dark) , But makes the fog a little more dark/intense when your underwater.
Reflection under water has been fixed.
The under water effect also work above water and can be controlled using lua.
SetShaderVariable(1.0, 40.0, 0.0135, 0.17) -- (0=Off 1=On, Speed , Distortion , Scale)
I removed "Head Bobbing" when your under water,makes movement in water better.

All of this is truly amazing.

Wow

Mr Teabone Sir. thank you for all your hard work with the swimming its awesome.

I have to ask if it would be possible when you are going to submit your work for the swimming on Github
would it then only be available for dx11 or could it be possible to even be made available for the other users on the older dx9 build , because i think a lot of users will for now stay at the previous build.
it would be awesome if you can arrange so that it would be available for us also somewhere with a update for the dx9 if possible , as i am back on the dx9 build to work on my oil rig.

i know for a fact that my character is going to fall of the oil rig and then i need him to be able to also swim in this dx9 build.

Please found out if we can have an update for the dx9 build also with your amassing work.

Thank you.
Pcs

Preben that is incredible!

At the moment I have put off the script a bit as there are some new tweaks coming to the player controls I noticed and I don't wish to complicate things. Also having an issue with the encoding of the LUA script I've been uploading where it doesnt compare properly with the master. If I can figure out that issue, I will for sure upload what I have as its still quite usable even if its not 100% swimming yet.



The upload to github will include some of the tweaks from the dx11 releases. I could however make a dx9 compatible version for everyone. I would just need someone to send me over the global player controls LUA script. Then I'll upload the modification here for everyone still using dx9.

Fantastic !!
What happened about Corno_1's water sliders ?
Are they to be implemented at all ?

now this is the best thread at the moment awesome incredible work guys

If there was ever an example of why adding GitHub community collaboration was a good idea, this is probably the best so far I am settling into bug fixing mode over the next two weeks so won't be adding any new features during this time, but of course the branch for this cool feature can still be accessed once available and everyone is absolutely invited to download, compile and check out the improvements ahead of a master merge later in April. I think it's fair to say Teabone and Preben are doing a far better job of underwater swimming than I could, and I'm so grateful and humbled to know our community has so many skilled people in it

@synchromesh
This feature is ready to deploy, but after Lee will not add any new features for this build, I decided to wait. So I can merge the latest changes in my branch and it is easier for Lee.
But if you feel saver, I can push it in a branch

While working on this mechanism I have put in a lot of consideration into not deviating from the original design that Lee has created for Game Guru's standard game play style. That is why you do not see an air-meter in this modification.

The style of reference I am using is very similar to Skyrim, in that no graphic jumps on the screen to show you an air-meter that may conflict with the users design choices. I am open to creating a new variable for the airtime in the future so that it can be used for additional user generated scripts for those that wish to create an air-metre of their own in their own design.

Here is an example of the drowning mechanism that exists in Skyrim, which I find to be the perfect reference as it very much aligns with Game Guru's current drowning system setup, that I'm now utilizing the original variables for in my modification:



You'll notice the health regeneration system in Skyrim doesn't start till the player's head is above the water. In Game Guru health regeneration is completely optional depending on the users intended game play style. This modifications Happens to work exactly the same as Skyrim; so i think this game is the perfect reference here for this type of mechanic.

If a Game Guru user decides they want to have health regeneration in their game or not, it will not affect the new drowning effect and the drowning effect will not effect health regeneration. If you have health regeneration on, you will only regain health once your head is above the water. Again, the same as Skyrim. If you have it off, it will not regenerate health automatically. So have no worries there.

You'll also notice the player enables random sounds for walking in shallow waters and a constant underwater loop plays once your head is below the waterline. I am considering playing around with new sound designs for underwater loop and other areas of underwater play; that way you don't hear splashing and breathing when swimming around underwater which is more typically for wading with the head above water. I do do foley sound design for film so this may help here.



I have my doubts! lol I should add that currently this is more of an improved drowning mechanism first and foremost. A lot of additional work is still needed to get swimming to work perfectly. A lot of of testing required there as some additions might break other functions. So I have not yet added those in yet. The current mod I've not detected any conflicting bugs yet. I think having this mod in its current states its great for those that wish to take advantage of the new ability to enter water and we can build onto it later to get it work and feel more like the AAA games.

This modification should also help support Corno's mod as it will prevent the player from instantly dying during test game when you move the water height slider above the player's head. I'm trying to be as considerate as possible with anything I upload to the github. Also! If for any reason anything i post is rejected, i would not at all be phased by this as I'd gladly use them for my own games I'm working on which is where my primary motivation is coming from.

I really need help from someone experienced with Github. Whenever I upload the gameplayercontrols.lua script mod it shows the entire file as conflicting. Yet in absolutely any and every program I use and can find it does not do this.

Github Pull Request: (includes latest master tweaks to the same script)
https://github.com/TheGameCreators/GameGuruRepo/pull/154/files

Examples in the attachments (not sure why the forums no longer shows thumbnails. The compare issue is a problem i cannot seem to get around and i need assistance.

EDIT: Going to take a bit of a break. The github stuff is giving me a bit of a headache

Hi Teabone this is brilliant work thank you

your attachments wont show because the forums are running on a unix system so the file extensions need to be lowercase

@Teabone

Make a backup somewhere else (i.e. Desktop). Then revert the whole master branch(also push it) and copy the backuped file over it. Then commit and push it again. You should have a clean commit which just shows the changes

what we need is our physics team to adapt and add to the under water scenarios, this means that things float drift and currents and different heights underwater regarding buoyancy. in the end preben teabone corno and say amen and stab could create the most aaa version of swimming underwater visuals this side of the galaxy. in the end i am seeing team work, challenges, dedication and positive brilliance , and good citizens of planet guru creating a symphony of creativity. i tip my hat to you guys

Teabone: I think your problem is your making your pull from your fork that are way behind in commits, so it cant say if any of the missing commits in your fork would change the files. so try to update your fork first and then try to make the commits/pull from your fork.

Teabone3/GameGuruRepo: "This branch is 6 commits ahead, 100 commits behind TheGameCreators:master."

Your pull: "Teabone3 wants to merge 6 commits into TheGameCreators:master from Teabone3:master"

Or you could create a normal branch on "TheGameCreators/GameGuruRepo" , and commit/pull this way.

Well done, just hoping that this becomes officially part of GG

So good to see this, it looks very promising.

Lee if your reading this don't attempt to merge yet (its messy). Going to see if i can get my branch updated first and then attempt to make the update appropriately.

Also if you move sliders while under water, the water will disappear and reappear constantly while you move them, forcing the player to fall. I'm guessing this is due to how the scene is rendered when modifying a slider. This will pose a possible problem with the water height slider.