Product Chat / GitHub Branch Testing

Author
Message
LeeBamber
TGC Lead Developer
24
Years of Service
User Offline
Joined: 21st Jan 2000
Location: England
Posted: 9th Mar 2018 15:59
Hi All,

We're nicely underway using GitHub for free collaboration, and are almost ready to greenlight the donation system, and the 'specific feature' projects will be handled by TGC, but the last element we need to look at is the testing of GitHub branches which are not quite ready for merging with the master but do need some external testing to make sure they are fine.

If you would be interested in casting your eye over some new features for ten minutes, you can find the first branch to undergo some testing here: https://github.com/TheGameCreators/GameGuruRepo/tree/Lua_New_Physics_Commands

Essentially, you need to clone the repo then switch to this branch and compile Guru-MapEditor.exe as part of the GameGuru installation. You can then look at the commit notes to see what has been added, and then confirm those additions work as expected and are stable. If you want to have a go, but need help, best to post questions and thoughts here so we can keep the answers in one place. Once we've done this process a few times, I will likely create a Wiki document for it so we have a central place to keep what we have learned easily accessible.
PC SPECS: Windows 8.1 Pro 64-bit, Intel Core i7-5930K (PASSMARK:13645), NVIDIA Geforce GTX 980 GPU (PASSMARK:9762) , 32GB RAM

AmenMoses
GameGuru Master
8
Years of Service
User Offline
Joined: 20th Feb 2016
Location: Portsmouth, England
Posted: 9th Mar 2018 16:12
As that happens to be my branch I'd like to point out that I am after more of a code review than a functional test for now, I'm not very conversant with C/C++ stuff so if I've done something really stupid without realising it I'd very much appreciate some feedback on that end of things.

The code I've pushed so far has already had some changes my end so expect another push as soon as those changes have been tested to my satisfaction.

@Lee, is there a definition somewhere for the internal t.tshape variable, i.e. what values it's safe to use. I was a bit puzzled at first that it doesn't match the collisionmode but for now I've used a tshape value of 6 for the sphere (collision mode 2) and plan on adding a cyclinder next so was going to use 7 (neither 6 or 7 seem to be used in the code anywhere but if you have them earmarked for something else let me know).
Been there, done that, got all the T-Shirts!
PM
Corno_1
GameGuru Tool Maker
13
Years of Service
User Offline
Joined: 3rd Nov 2010
Location:
Posted: 9th Mar 2018 22:13
Are there no beta testers? That sound a bit too complicated for normal users...
Ebe Editor Free - Build your own EBE structures with easy and without editing any text files
Thread and Download
PM
granada
Forum Support
21
Years of Service
User Offline
Joined: 27th Aug 2002
Location: United Kingdom
Posted: 9th Mar 2018 23:33
Quote: "Are there no beta testers? That sound a bit too complicated for normal users..."


Even some beta testers .

Dave
Windows 10 Pro 64 bit
GeForce GTX 1050 Ti
AMD FX (tm)-9590 Eight-core Processor
31.96 GB RAM
1920x1080,60 Hz
PM
Corno_1
GameGuru Tool Maker
13
Years of Service
User Offline
Joined: 3rd Nov 2010
Location:
Posted: 10th Mar 2018 12:27
We have beta testers? Why we not give them a compiled version of this branch and let them try it? I find it shouldn´t be the task for a beta tester to compile it. Beta testers should have no clue about the source so they can test it without any knowledge like any other user.

It should be a better way of organizing devs and beta testers than this, like a hidden sub forum or similar.
Ebe Editor Free - Build your own EBE structures with easy and without editing any text files
Thread and Download
PM
AmenMoses
GameGuru Master
8
Years of Service
User Offline
Joined: 20th Feb 2016
Location: Portsmouth, England
Posted: 10th Mar 2018 13:11
You don't need to compile the code to cast an expert eye over it and let me know if I've made any glaring mistakes!
Been there, done that, got all the T-Shirts!
PM
Stab in the Dark software
GameGuru TGC Backer
21
Years of Service
User Offline
Joined: 12th Dec 2002
Location: Upstate New York USA
Posted: 10th Mar 2018 20:07
I would assume that Lee should be the one to look over the code and see if it is good, bad or indifferent.
Since most GitHub repos have some C++ coding rules created by the author.
The coffee is lovely dark and deep,and I have code to write before I sleep.
LeeBamber
TGC Lead Developer
24
Years of Service
User Offline
Joined: 21st Jan 2000
Location: England
Posted: 12th Mar 2018 14:33
Think of branch review and a slice between the contributor and the act of me merging it into the main branch (at which time I cast my eye over every line before anything gets into the main code). This step (if anyone wants the task) allows a contributor to sanity check their work before I take a final look before merging, which means I can spend more time on other areas. The beta build is a stage later on, when the contributions have been merged to the main branch, tested by me, and then handed over to the beta testing group. The public preview is then the stage after the beta build when it goes out to more users to test, which often finds things the smaller groups missed. It's a long process from idea to deliverable, but there is no such thing as too little testing
PC SPECS: Windows 8.1 Pro 64-bit, Intel Core i7-5930K (PASSMARK:13645), NVIDIA Geforce GTX 980 GPU (PASSMARK:9762) , 32GB RAM

Login to post a reply

Server time is: 2024-04-16 08:58:20
Your offset time is: 2024-04-16 08:58:20